Moti Asayag has posted comments on this change.
Change subject: core: seperating code to enable working with cluster 3.0 and 3.1
......................................................................
Patch Set 1: (6 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java
Line 48: if
(VmDeviceCommonUtils.isOldClusterVersion(vm.getvds_group_compatibility_version()))
please wrap the if-else block with brackets {}.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 117: struct.add(VdsProperties.ReadOnly, new
Boolean(vmDevice.getIsReadOnly()).toString());
please replace with String.valueOf(vmDevice.getIsReadOnly())
Line 172: struct.add(VdsProperties.ReadOnly, new
Boolean(vmDevice.getIsReadOnly()).toString());
please replace with String.valueOf(vmDevice.getIsReadOnly())
Line 172: struct.add(VdsProperties.ReadOnly, new
Boolean(vmDevice.getIsReadOnly()).toString());
please replace with String.valueOf(vmDevice.getIsReadOnly())
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmOldInfoBuilder.java
Line 31: (new Integer(vm.getnum_of_monitors())).toString());
use String.valueOf(vm.getnum_of_monitors()) instead.
Line 55: VmDevice vmDevice =
This variable isn't being used anywhere, is this DB access requires then ?
--
To view, visit http://gerrit.ovirt.org/2409
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1e9c0cf5277b5c54f5909c8b34d021c9651bd1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
