Eli Mesika has posted comments on this change.
Change subject: core: getting disk of vm and templates diffrently
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
Line 369: VM vm =
DbFacade.getInstance().getVmDAO().get(vmBaseInstance.getId());
too complex to handle now, we will try to push it all together
Line 457: if (entity instanceof VmTemplate) {
That's exactly what I said in my comment that for VMs the getImages method
brings the right content and for Templates getDiskList
....................................................
Commit Message
Line 7: core: getting disk of vm and templates diffrently
Done
Line 17: I will be happy to get any comments or suggestions for improvements on
that.
Don't think you got me , se my comments inside code
--
To view, visit http://gerrit.ovirt.org/2416
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9726492eb401b5c86562757905c2fd84b7c12ffc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
