Eli Mesika has posted comments on this change. Change subject: core: Update VM devices on DB when hash changes ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java Line 892: DbFacade.getInstance().getVmDeviceDAO().remove(device.getId()); ignore my next comment, AFAIK this handles only mass updates , can you elaborate please ? Line 924: DbFacade.getInstance().getVmDeviceDAO().save(newDevice); ignore my next comment, this is a new entity , this mechanism handles only mass updates or am I missing something ? -- To view, visit http://gerrit.ovirt.org/2410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia963db83d88cb11c57be197c40d64f1e1b3c88c9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
