Yair Zaslavsky has posted comments on this change. Change subject: core: Improve exception handling in end actions ......................................................................
Patch Set 1: Looks good to me, approved (1 inline comment) just add the minor comment and merge. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java Line 358: logExceptionAndCompensate(e); please add some comments here explaining why we still perform compensate if we fail to cleanup . -- To view, visit http://gerrit.ovirt.org/2446 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40f6c12512c5b71b16c1de0d97a509848e8a4beb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
