Vojtech Szocs has uploaded a new change for review. Change subject: webadmin: Resizable table columns, take two ......................................................................
webadmin: Resizable table columns, take two Improved the original concept submitted by Gilad. This is a concept, do not merge this unless we accept this solution. All table columns are now resizable by default. Fixed-width column support can be easily added later. Each column header now contains a resize handle, located on the right edge of the header. When the mouse hovers over the resize handle, mouse cursor changes its shape to indicate that resize can take place. There are no limitations on columns in order to become resizable (there's no need to define explicit column width). Implementation details: - upon column resize, only the resized column's width is recalculated, other columns are resized automatically by the browser - removed CSS 'width:100%' on <table> element, which caused crazy resize behavior - removed AbstractActionTable#addColumnWithHtmlHeader() due to code consistency reasons (if we need HTML support in table headers, we should implement it on top of the resizable header) However, there's one thing to note: since <table> CSS 'width:100%' has been removed, some headers might appear shorter now. This can be easily fixed by updating their widths in the code. Change-Id: I447cf738cfd955d13bcafc5aaa5ad0f114458d11 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeHandler.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ResizableHeader.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ResizableHeaderCell.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/PopupCellTable.css M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/TabCellTable.css A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/resize_handle.png M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostConfigureLocalStoragePopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java 10 files changed, 197 insertions(+), 32 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/33/2433/1 -- To view, visit http://gerrit.ovirt.org/2433 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I447cf738cfd955d13bcafc5aaa5ad0f114458d11 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
