Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: yaml: remove obselete use of m2crypto due to BZ#601 fixed
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40732
To
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Added possible json option value encoding
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/35238/1/mock_configs
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: changed jpackage mirror
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34849
To unsubscribe, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: jobs: vdsm_master_create-rpms_merged
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32512
To unsubscribe, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: repoclosure: changed epel mirror
..
Patch Set 1: Code-Review+1
There was no mirrorlist option, right?
--
To view, visit http://gerrit.ovirt.org
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Added ioprocess jobs
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29531
To unsubscribe, visit http://gerrit.ovirt.org
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: enable el7 builds for hosted engine
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/30752
To unsubscribe, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Added ioprocess jobs
..
Patch Set 1:
Lots of duplication with http://gerrit.ovirt.org/#/c/30510/ since both add
build_mock_srcrpm.sh so could you
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: jobs: ovirt-hosted-engine-setup
..
Patch Set 8: Code-Review-1
(4 comments)
http://gerrit.ovirt.org/#/c/30510/8/jobs/confs/shell-scripts
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Added ovirt-reports
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/30531
To unsubscribe, visit http://gerrit.ovirt.org
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: It releasever not set it adds centos to the distro
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/29354/2/mock_configs/epel-7-x86_64.cfg
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Added vdsm installation sanity
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29008
To unsubscribe, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Fixed config to adapt to the jjb fixes
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29223
To unsubscribe, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Added vdsm installation sanity
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/29008/2/jobs/confs/shell-scripts
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Added gerrit garbage collecting job
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28828
To unsubscribe, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Added job to deploy the yamls
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28825
To unsubscribe, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Added gerrit garbage collecting job
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28828
To unsubscribe, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: First yaml job, the one checking the yamls
..
Patch Set 8: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/28723/8/jobs/confs/shell-scripts
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: First yaml job, the one checking the yamls
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/28723/7/jobs/confs/shell-scripts/check_yaml.sh
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: First yaml job, the one checking the yamls
..
Patch Set 7:
(1 comment)
Ok, so this is just to verify that the new jobs aren't different fro
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: First yaml job, the one checking teh yamls
..
Patch Set 6:
Bit of both? It's hard to review if it does what it's supposed to do if I d
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: First yaml job, the one checking teh yamls
..
Patch Set 6: Code-Review-1
(1 comment)
I'm not sure what this actually tries to accomplish.
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: packaging: provide mirrorlist for oVirt repo
..
Patch Set 2:
I'd suggest to only roll this out to beta's for a week or so to see if the
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: packaging: provide mirrorlist for oVirt repo
..
Patch Set 1: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/27654/1/ovirt-release-3.4
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Fixed issue with non-existing config option
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27381
To unsubscribe, visit
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Adding some mock configurations
..
Patch Set 4:
I'd expect it to be able to build i386 on x86_64 and all distros as well. That
still means we
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Adding some mock configurations
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26433
To unsubscribe, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Adding some mock configurations
..
Patch Set 3: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/26433/3/mock_configs/epel-6-x86_64-ovirt
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Adding some mock configurations
..
Patch Set 3: Code-Review-1
(6 comments)
Not that familiar with mock, but I think you need a repository with the
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Adding some mock configurations
..
Patch Set 2: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/26433/2/mock_configs/.default.cfg.swp
File
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Fix update_engine_params to support repo links
..
Patch Set 10: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25291
To unsubscribe
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Use static repos for a new layout
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25295
To unsubscribe, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Fix update_engine_params to support repo links
..
Patch Set 7: Code-Review-1
The mixed whitespace makes it very hard to read.
--
To view, visit
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add LICENSE and AUTHORS to the project
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25137
To unsubscribe, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add generic code to check repoclosure
..
Patch Set 17: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24802
To unsubscribe, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add generic code to check repoclosure
..
Patch Set 15:
(1 comment)
http://gerrit.ovirt.org/#/c/24802/15/jobs/packaging/repo_closure_check.sh
File
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add generic code to check repoclosure
..
Patch Set 15: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/24802/15/jobs/packaging
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add generic code to check repoclosure
..
Patch Set 14:
(1 comment)
http://gerrit.ovirt.org/#/c/24802/14/jobs/packaging/repo_closure_check.sh
File
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add generic code to check repoclosure
..
Patch Set 12: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/24802/12/jobs/packaging
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add generic code to check repoclosure
..
Patch Set 11: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/24802/11/jobs/packaging
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add generic code to check repoclosure
..
Patch Set 4: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/24802/4/jobs/packaging
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add generic code to check repoclosure
..
Patch Set 3: Code-Review-1
(6 comments)
The indenting should be fixed, others are mostly questions.
http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Adding proper database setup
..
Patch Set 1: Code-Review-1
(1 comment)
Not sure about changing all the indenting.
http://gerrit.ovirt.org/#/c
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Added puppet check scripts
..
Patch Set 4:
Comments still from patch set 3. Also related:
https://github.com/vStone/jenkins-puppet-scripts
--
To
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Added puppet check scripts
..
Patch Set 3:
Since modules don't have to come from the forge (git is also a valid source),
I'm not in
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Added puppet check scripts
..
Patch Set 3:
I'm glad it was mailed to me, because gerrit messed up the layout. This it
properly indented so I
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Added puppet check scripts
..
Patch Set 3: Code-Review-1
(4 comments)
File jobs
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add new job update-engine-params
..
Patch Set 31:
(1 comment)
File jobs
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add new job update-engine-params
..
Patch Set 31:
(1 comment)
File jobs
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add new job update-engine-params
..
Patch Set 31: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21094
To unsubscribe, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add new job update-engine-params
..
Patch Set 24:
(1 comment)
File jobs
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add new job update-engine-params
..
Patch Set 24:
Yes, this in itself is useful and then we can improve it even further.
--
To view, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add new job update-engine-params
..
Patch Set 24:
I'd agree that'd be great, but currently Fedora is hardcoded in the repo. It
also uses
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add new job update-engine-params
..
Patch Set 24: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21094
To unsubscribe, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add new job update-engine-params
..
Patch Set 23: Code-Review-1
(1 comment)
File jobs
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add new job update-engine-params
..
Patch Set 22: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21094
To unsubscribe, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add new job update-engine-params
..
Patch Set 20: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21094
To unsubscribe, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add new job update-engine-params
..
Patch Set 13:
(5 comments)
I think this could be a great script. Just some suggestions to make it easier
to
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add new job update-engine-params
..
Patch Set 11:
(1 comment)
File jobs
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add new job update-engine-params
..
Patch Set 11:
(1 comment)
File jobs
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add new job update-engine-params
..
Patch Set 11: Code-Review-1
(8 comments)
File jobs
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: network cleanup scripts
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20364
To unsubscribe, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: network cleanup scripts
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20364
To unsubscribe, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: network cleanup scripts
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20364
To unsubscribe, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: network cleanup scripts
..
Patch Set 1: Code-Review-1
(4 comments)
File scripts
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Backup plugins directory only on Sunday
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Backup plugins directory only on Sunday
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline co
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: jenkins: adding manainnace script for nightly builds
..
Patch Set 2: I would prefer that you didn't submit this
Please check me comments o
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: jenkins: adding manainnace script for nightly builds
..
Patch Set 1: I would prefer that you didn't submit this
(7 inline com
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Use vncviewer passwordFile instead of passwdInput
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Use vncviewer passwordFile instead of passwdInput
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Use vncviewer passwordFile instead of passwdInput
..
Patch Set 1: I would prefer that you didn't submit this
(3 inline com
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: packaging: Adjust configuration when using PREFIX
..
Patch Set 7: Looks good to me, but someone else must approve
I agree the $(NULL) changes are
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: packaging: End list of dependencies in $(NULL)
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: packaging: Adjust configuration when using PREFIX
..
Patch Set 1: (1 inline comment)
File
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: packaging: Introduce make.py
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline co
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: packaging: Introduce make.py
..
Patch Set 1:
Have you considered using Waf (https://code.google.com/p/waf/)? I agree with
Alon you should use as
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
Patch Set 1: (1 inline comment
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
Patch Set 1: (1 inline comment
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
Patch Set 1: (11 inline comments)
Mostly style comments
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: core: introduce new libosinfo query
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9047
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: UI: libosinfo - validate VM minimum RAM with libosinfo
..
Patch Set 2: I would prefer that you didn't submit this
(5 inline comments)
Rel
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: packagin: libosinfo - add libosinfo RPM dependency
..
Patch Set 5: I would prefer that you didn't submit this
(1 inline co
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: core: libosinfo delete unused queries
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: core: WIP introduce new libosinfo query
..
Patch Set 5: Looks good to me, but someone else must approve
(1 inline comment)
Not going to block on
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: core: WIP libosinfo add mapping for libosinfo shortids.
..
Patch Set 3: I would prefer that you didn't submit this
(4 inline comments)
M
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: core: WIP - libosinfo UI - create a renderer for VmOsType labels
..
Patch Set 3: I would prefer that you didn't submit this
(2 inline com
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: core: WIP - libosinfo delete unused queries
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: core: WIP introduce new libosinfo query
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
Rather trivial co
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: core: WIP - libosinfo - introduce libosinfo service
..
Patch Set 4: I would prefer that you didn't submit this
(11 inline com
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: core: WIP - libosinfo - introduce libosinfo service
..
Patch Set 3: (1 inline comment)
File
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: core: WIP - libosinfo - introduce libosinfo service
..
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
Not that d
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: core: Libosinfo service Xml loading impl
..
Patch Set 4: I would prefer that you didn't submit this
(3 inline com
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Avoid slient success of ISO uploading
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Minor
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: packaging: Renamed 'rhevm' to 'ovirt-engine' in iptables
(#773583)
..
Patch Set 1: Verified
Ok, just wanted to confirm.
--
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: packaging: Renamed 'rhevm' to 'ovirt-engine' in iptables
(#773583)
..
Patch Set 1:
Btw, looking at the bug it looks like you
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: packaging: Renamed 'rhevm' to 'ovirt-engine' in iptables
(#773583)
..
Patch Set 1: Looks good to me, but someone else must
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: packaging: Replace pubkey2ssh with ssh-keygen
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: packaging: Replace pubkey2ssh with ssh-keygen
..
Patch Set 1: (1 inline comment)
Note that RHEL 6 has openssh 5.3. I'm no expert on f
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: tools: Make system and REST API rebase
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
1 - 100 of 104 matches
Mail list logo
