Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: First yaml job, the one checking the yamls ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/28723/7/jobs/confs/shell-scripts/check_yaml.sh File jobs/confs/shell-scripts/check_yaml.sh: Line 32: diff -u "$old_xmls_dir" "$new_xmls_dir" \ Line 33: | "$WORKSPACE/jenkins/jobs/confs/shell-scripts/htmldiff.sh" \ Line 34: > "$WORKSPACE/differences.html" || res=1 Line 35: [[ $res -ne 0 ]] \ Line 36: || { > A regular what? Can you elaborate? I'd think this is the same as: if [[ $res -ne 0 ]] ; then ... fi Since diff returns 0 when the files are equal. But as it now reads, I think your logic is reversed. An if statement is easier to read. Line 37: echo "WARNING: #### XML CHANGED ####" Line 38: echo "Changed files:" Line 39: diff -q "$old_xmls_dir" "$new_xmls_dir" | awk '{ print $2 }' || : Line 40: } -- To view, visit http://gerrit.ovirt.org/28723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a48a2757bc241e2b8155c74de54bcc6335ee159 Gerrit-PatchSet: 7 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
