Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: packaging: Adjust configuration when using PREFIX ......................................................................
Patch Set 1: (1 inline comment) .................................................... File Makefile Line 151: install_sec \ Line 152: install_aio_plugin \ Line 153: install_jboss_modules \ Line 154: install_service \ Line 155: adjust_defaults Can you escape the line ending and add $(NULL) on a separate line? That way you'll get smaller diffs next time you edit it. Line 156: Line 157: tarball: Line 158: sed -e 's/@PACKAGE_VERSION@/$(RPM_VERSION)/g' \ Line 159: -e 's/@PACKAGE_RELEASE@/$(RPM_RELEASE_VERSION)/g' $(SPEC_FILE_IN) > $(SPEC_FILE) -- To view, visit http://gerrit.ovirt.org/10982 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69042e4c959a8849a370b458d2304fbf9d6ab0c4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
