Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: core: WIP introduce new libosinfo query ......................................................................
Patch Set 5: Looks good to me, but someone else must approve (1 inline comment) Not going to block on the comma, but still an inline comment. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java Line 292: // os info queries Line 293: GetOsInfoMap, Line 294: Line 295: // Default type instead of having to null check Line 296: Unknown(VdcQueryAuthType.User), ; I don't see an added value in adding this comma. Line 297: Line 298: /** Line 299: * What kind of authorization the query requires. Although this is essentially a <code>boolean</code>, it's Line 300: * implemented as an enum for future extendability. -- To view, visit http://gerrit.ovirt.org/9047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I802d4e5abbefc30fc72c586f29db3875882a86c4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
