Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: Backup plugins directory only on Sunday
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File backup/backup-jenkins.sh
Line 21: pushd "${JENKINS_DIR}"
Line 22: find -maxdepth 1 -type f -name "*.xml" > "${JENBAKLISTFILE}"
Line 23: find users \
Line 24:      userContent \
Line 25:      "${BACKUP_PLUGINS}" >> "${JENBAKLISTFILE}"
This will give an error that "" could not be found on all days but Sunday. I 
think that if you leave the quotes, it will work better.
Line 26: find -H jobs -maxdepth 2 -name "config.xml" -type f >> 
"${JENBAKLISTFILE}"
Line 27: tar czvf "${BACKUP_DIR}"/jenkins-backup-$(date 
+"%Y-%m-%d_%H_%M_%S").tgz -T "${JENBAKLISTFILE}"
Line 28: popd
Line 29: 


-- 
To view, visit http://gerrit.ovirt.org/16063
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I685c026a7b9d882297aa43c84527d1a7a774b210
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: David Caro <dcaro...@redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to