Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Add generic code to check repoclosure ......................................................................
Patch Set 11: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/24802/11/jobs/packaging/repo_closure_check.sh File jobs/packaging/repo_closure_check.sh: Line 3: LAYOUT="" Line 4: BASE_URL="http://resources.ovirt.org"; Line 5: CENTOS_MIRROR="http://centos.mirror.constant.com/"; Line 6: FEDORA_MIRROR="http://mirrors.kernel.org/fedora/"; Line 7: FEDORA_UPDATES_MIRROR="http://mirrors.servercentral.net/"; Why use a different mirror for updates than releases? Line 8: GLUSTER_MIRROR="http://download.gluster.org/"; Line 9: JPACKAGE_MIRROR="ftp://jpackage.hmdc.harvard.edu/"; Line 10: Line 11: die() { Line 27: ${0} --distribution=fc --layout=new --distribution-version=20 --repo=test-repo Line 28: ${0} --distribution=el --layout=new --distribution-version=6 --repo=test-repo Line 29: Line 30: old layout: Line 31: ${0} --distribution=Fedora --layout=old --distribution-version=20 --repo=test-repo This should be fc instead of Fedora as well. Line 32: ${0} --distribution=EL --layout=old --distribution-version=6 --repo=test-repo Line 33: __EOF__ Line 34: } Line 35: -- To view, visit http://gerrit.ovirt.org/24802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I762abf97c9020301a388f7d83c7d1e41bdf1f062 Gerrit-PatchSet: 11 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
