Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: core: WIP libosinfo add mapping for libosinfo shortids. ......................................................................
Patch Set 3: I would prefer that you didn't submit this (4 inline comments) Mostly nagging about whitespace and comments. +1 on the idea. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmOsType.java Line 22: Windows2008R2x64(17, "win2k-8"), Line 23: RHEL6(18, "rhel-6.0"), Line 24: RHEL6x64(19, "rhel-6.0"), Line 25: Line 26: // bsd How about aligning the comments and separate groups by empty lines? Line 27: freebsd6(1, "freebsd6"), Line 28: freebsd7(2, "freebsd7"), Line 29: freebsd8(3, "freebsd8"), Line 30: openbsd4(4, "openbsd4"), Line 29: freebsd8(3, "freebsd8"), Line 30: openbsd4(4, "openbsd4"), Line 31: // centos Line 32: centos__6_0(101, "centos-6.0"), Line 33: centos__6_1(102, "centos-6.1"), Inconsistent indentation here. Line 34: // debian Line 35: debianbuzz(201, "debianbuzz"), Line 36: debianrex(202, "debianrex"), Line 37: debianbo(203, "debianbo"), Line 59 Line 60 Line 61 Line 62 Line 63 I would just ignore this line in this patch, but feel free to ignore me here ;) Line 62: linux26(402, "linux26"), Line 63: linuxvirtio26(403, "linuxvirtio26"), Line 64: generic24(404, "generic24"), Line 65: generic26(405, "generic26"), Line 66: virtio26(406, "virtio26"), It looks like the last 3 are just generic, not generic-linux. Maybe change the comment to generic? Line 67: // mandriva Line 68: mandriva2009(501, "mandriva2009"), Line 69: mandriva2010(502, "mandriva2010"), Line 70: mes5(503, "mes5"), -- To view, visit http://gerrit.ovirt.org/9057 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b1e51a99d107d79bf89149b66f46a73362e9ca7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
