Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: core: WIP - libosinfo UI - create a renderer for VmOsType labels
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
Line 572: return ((VmTemplate) object).getname();
Line 573: }
Line 574: });
Line 575:
Line 576: // oSTypeEditor = new ListModelListBoxEditor<Object>(new
EnumRenderer());
Not a fan of commenting old code. Please remove this line.
Line 577: oSTypeEditor = new ListModelListBoxEditor<Object>(new
NullSafeRenderer<Object>() {
Line 578: @Override
Line 579: public String renderNullSafe(Object object) {
Line 580: VmOsType osType = (VmOsType) object;
Line 573: }
Line 574: });
Line 575:
Line 576: // oSTypeEditor = new ListModelListBoxEditor<Object>(new
EnumRenderer());
Line 577: oSTypeEditor = new ListModelListBoxEditor<Object>(new
NullSafeRenderer<Object>() {
Any reason you don't make it NullSafeRenderer<VmOsType>? It would save you a
typecast.
Line 578: @Override
Line 579: public String renderNullSafe(Object object) {
Line 580: VmOsType osType = (VmOsType) object;
Line 581: Os os =
AsyncDataProvider.getAllOSs().get(osType.getShortId());
--
To view, visit http://gerrit.ovirt.org/9056
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbc83e28a78d0214a5b08f8c6d2606e9ac017f33
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
