Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: First yaml job, the one checking the yamls ......................................................................
Patch Set 8: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/28723/8/jobs/confs/shell-scripts/check_yaml.sh File jobs/confs/shell-scripts/check_yaml.sh: Line 33: | "$WORKSPACE/jenkins/jobs/confs/shell-scripts/htmldiff.sh" \ Line 34: > "$WORKSPACE/differences.html" \ Line 35: || changed=true Line 36: Line 37: if $changed; then Much easier to read. Line 38: echo "WARNING: #### XML CHANGED ####" Line 39: echo "Changed files:" Line 40: diff -q "$old_xmls_dir" "$new_xmls_dir" | awk '{ print $2 }' || : Line 41: fi -- To view, visit http://gerrit.ovirt.org/28723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a48a2757bc241e2b8155c74de54bcc6335ee159 Gerrit-PatchSet: 8 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
