Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/CrowdBrokerUtils.java
Line 35:
Line 36: public class CrowdBrokerUtils {
Line 37:
Line 38: /* have we previously init'ed Crowd? */
Line 39: private static boolean crowdok = false;
What I suggested was that in initCrowd() you first use a local variable to set
it up. When you've loaded all (so where crowok = true) you do m_CrowdClient =
tempCrowdClient instead. That way you only need an extra static variable but
just a local one in initCrowd.
Line 40:
Line 41: private static Log log = LogFactory.getLog(CrowdBrokerUtils.class);
Line 42: /* The Couwd Client */
Line 43: static CrowdClient m_CrowdClient;
--
To view, visit http://gerrit.ovirt.org/9324
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide867f16d092eb329c0ce2fccf4ebd02f3aae0df
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Justin Hammond <jus...@dynam.ac>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Justin Hammond <jus...@dynam.ac>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
