Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: core: WIP introduce new libosinfo query ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) Rather trivial comment inline, in general I see no issues. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java Line 291: GetOsInfoMap, Line 292: GetOsInfoById, Line 293: Line 294: // Default type instead of having to null check Line 295: Unknown(VdcQueryAuthType.User), ; Not sure what this comma adds. Maybe if you move the semi-colon to the next line the comma adds value, but you still modify the line if you add more. Line 296: Line 297: /** Line 298: * What kind of authorization the query requires. Although this is essentially a <code>boolean</code>, it's Line 299: * implemented as an enum for future extendability. -- To view, visit http://gerrit.ovirt.org/9047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I802d4e5abbefc30fc72c586f29db3875882a86c4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
