Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: core: WIP - libosinfo - introduce libosinfo service ......................................................................
Patch Set 3: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmOsType.java Line 10: OtherLinux(5, OsType.Linux, false, ""), Line 11: Other(6, OsType.Other, false, ""), Line 12: RHEL5(7, OsType.Linux, false, "rhel-5.4"), Line 13: RHEL4(8, OsType.Linux, false, "rhel-4.8"), Line 14: RHEL3(9, OsType.Linux, false, "rhel-3"), Looks good. I especially like moving from the simple appending numbers to grouping in the hundreds. Line 15: Windows2003x64(10, OsType.Windows, true, "win2k3"), Line 16: Windows7(11, OsType.Windows, false,"win7"), Line 17: Windows7x64(12, OsType.Windows, true,"win7"), Line 18: RHEL5x64(13, OsType.Linux, true, "rhel-5.4"), -- To view, visit http://gerrit.ovirt.org/8472 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I663dbae36d583ca4c524b2957a9a695e44207975 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
