Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: jobs: ovirt-hosted-engine-setup ......................................................................
Patch Set 8: Code-Review-1 (4 comments) http://gerrit.ovirt.org/#/c/30510/8/jobs/confs/shell-scripts/build_mock_srcrpm.sh File jobs/confs/shell-scripts/build_mock_srcrpm.sh: Line 10: % Spurious % there. Line 20: # extra-build-options Line 21: # space separated list of extra options to pass to the build.sh script Line 22: # Line 23: # extra-rpmbuild-options Line 24: # extra options to pass to rpmbuild as defines, as a spaceseparated list Ironically missing a space in spaceseparated. Is that intentional? :) Line 25: # of key=value pairs Line 26: # Line 27: # extra-repos Line 28: # List of extra repositories to use when building, in a space separated list Line 67: --base="$distribution-$arch.cfg" \ Line 68: --option="basedir=$WORKSPACE/mock/" \ Line 69: $mock_repos \ Line 70: > "$mock_conf.cfg" Line 71: sudo touch /var/cache/mock/*/root_cache/cache.tar.gz || : What does this? Doesn't this reuse the cache indefinitely since it'll always be up to date? Line 72: cat "$mock_conf.cfg" Line 73: popd Line 74: Line 75: ## prepare the command line Line 149: "${{rpmbuild_options[@]}}" \ Line 150: -ts *.gz Line 151: Line 152: Line 153: mkdir /tmp/SRCRPMS Please use mktemp for this. Line 154: mv *.tar.gz /tmp/SRCRPMS/ Line 155: mv *src.rpm /tmp/SRCRPMS/ Line 156: EOF Line 157: -- To view, visit http://gerrit.ovirt.org/30510 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10a908a2be067d38616c41a2c2e6cb3effc9c787 Gerrit-PatchSet: 8 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
