Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Added puppet check scripts
......................................................................
Patch Set 3:
I'm glad it was mailed to me, because gerrit messed up the layout. This it
properly indented so I think it renders correctly now.
.
|-custom_modules -> our custom modules, not from the forge, reusable and
independent (only using forge modules if any)
| |-mod1
| | |-manifests
| | | `-init.pp
| | |-spec # rspec test directory example
| | | |-classes
| | | | `-mod1_spec.rb
| | | `-fixtures
| | | |-manifests
| | | | `-site.pp
| | | `-modules ## link to any modules you need appart from itself
| | | `-mod1
| | | |-manifests -> ../../../../manifests
| | | `-templates -> ../../../../templates
| | `-templates
| | `-tpl1.erb
| `-mod2
| |-manifests
| |-spec
| `-templates
|-modules ## only forge modules here
| `-mod1
| |-manifests
| |-spec
| `-templates
|-profiles ## Service oriented modules, they might use the custom mods and
forge mods, give full functionality, like 'jenkins_slave' or 'nagios_server'
| `-mod1
| |-manifests
| |-spec
| `-templates
`-site.pp ## global defaults
If you look at https://github.com/adrienthebo/r10k#git-repository-layout you
see they suggest the following:
.
├── Puppetfile # An optional Puppetfile
├── dist # Internally developed generic modules
└── site # Modules for deploying custom services
I followed this (with modules for forge modules). Site would be profiles in
your layout. We could add dist which is your custom_modules. So idea wise we're
on the same line and IMHO it's mostly bike shedding on names. I'd prefer using
the same as r10k, but I have no very strong preference.
--
To view, visit http://gerrit.ovirt.org/22276
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b780ae35a9f8f9bb779bc16f7c2340394d3b8e7
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaro...@redhat.com>
Gerrit-Reviewer: David Caro <dcaro...@redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Ohad Basan <oba...@redhat.com>
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
