Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Adding proper database setup ......................................................................
Patch Set 1: Code-Review-1 (1 comment) Not sure about changing all the indenting. http://gerrit.ovirt.org/#/c/24781/1/jobs/ovirt_engine_upgrade_params/update_engine_params.sh File jobs/ovirt_engine_upgrade_params/update_engine_params.sh: Line 30: service postgresql stop Line 31: yum remove -y postgresql-server Line 32: fi Line 33: [[ -d /var/lib/pgsql/data ]]\ Line 34: && rm -rf /var/lib/pgsql/data rm -rf also exits with 0 if the directory never existed in the first place, so checking is redundant. Line 35: yum -y install postgresql-server Line 36: postgresql-setup initdb || res=$(($res + $?)) Line 37: ## ugly fig for the tests to work Line 38: cat >/var/lib/pgsql/data/pg_hba.conf <<EOF -- To view, visit http://gerrit.ovirt.org/24781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d9daebdb557880a63d8eeca5c838d28d3808b1e Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
