Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: packaging: Introduce make.py
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File builders.py
Line 288: os.remove(childPath)
Line 289: else:
Line 290: shutil.rmtree(childPath)
Line 291:
Line 292: def findLocalPaths(self, base, name):
This feels a lot like glob.glob.
Line 293: self.logLine("Searching for files with name \"%s\""
Line 294: " in directory \"%s\"." % (name, base))
Line 295:
Line 296: pending = [base]
--
To view, visit http://gerrit.ovirt.org/10539
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3069fae1a21d1d9058c1915acd362fe2d5f8ea2a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
