dramaticlly commented on PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#issuecomment-2539699512
Thank you @danielcweeks @szehon-ho @pvary @kevinjqliu @gaborkaszab
@haizhou-zhao for the review! I will look into similar change for hive view
existence check
--
This is an autom
danielcweeks commented on PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#issuecomment-2539677480
Thanks @dramaticlly !!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
danielcweeks merged PR #11597:
URL: https://github.com/apache/iceberg/pull/11597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceb
dramaticlly commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1879086639
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,43 @@ private void validateTableIsIcebergTableOrView(
}
}
+
danielcweeks commented on PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#issuecomment-2533223559
@dramaticlly minor comment, but other than that LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
danielcweeks commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1879074770
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,43 @@ private void validateTableIsIcebergTableOrView(
}
}
+
dramaticlly commented on PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#issuecomment-2533061166
@rdblue @danielcweeks can you help take anther look to see if we can move
forward on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the messa
pvary commented on PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#issuecomment-2528057081
@danielcweeks: If you don't have more comments here, then I think we could
merge this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
gaborkaszab commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1872741906
##
hive-metastore/src/test/java/org/apache/iceberg/hive/HiveTableTest.java:
##
@@ -388,6 +388,52 @@ public void
testHiveTableAndIcebergTableWithSameName(TableTyp
kevinjqliu commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1870085840
##
api/src/main/java/org/apache/iceberg/catalog/Catalog.java:
##
@@ -271,7 +271,7 @@ default Transaction newReplaceTableTransaction(
}
/**
- * Check whet
szehon-ho commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1870097657
##
api/src/main/java/org/apache/iceberg/catalog/Catalog.java:
##
@@ -271,7 +271,7 @@ default Transaction newReplaceTableTransaction(
}
/**
- * Check wheth
kevinjqliu commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1870088183
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,40 @@ private void validateTableIsIcebergTableOrView(
}
}
+
dramaticlly commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1869982424
##
api/src/main/java/org/apache/iceberg/catalog/Catalog.java:
##
@@ -271,7 +271,7 @@ default Transaction newReplaceTableTransaction(
}
/**
- * Check whe
danielcweeks commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1869827020
##
dell/src/main/java/org/apache/iceberg/dell/ecs/EcsCatalog.java:
##
@@ -372,6 +372,7 @@ public boolean namespaceExists(Namespace namespace) {
@Override
danielcweeks commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1869825824
##
api/src/main/java/org/apache/iceberg/catalog/Catalog.java:
##
@@ -271,7 +271,7 @@ default Transaction newReplaceTableTransaction(
}
/**
- * Check wh
dramaticlly commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1868763730
##
api/src/main/java/org/apache/iceberg/catalog/Catalog.java:
##
@@ -271,7 +271,7 @@ default Transaction newReplaceTableTransaction(
}
/**
- * Check whe
szehon-ho commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1868757904
##
api/src/main/java/org/apache/iceberg/catalog/Catalog.java:
##
@@ -271,7 +271,7 @@ default Transaction newReplaceTableTransaction(
}
/**
- * Check wheth
kevinjqliu commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1868686474
##
api/src/main/java/org/apache/iceberg/catalog/Catalog.java:
##
@@ -271,7 +271,7 @@ default Transaction newReplaceTableTransaction(
}
/**
- * Check whet
kevinjqliu commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1868686474
##
api/src/main/java/org/apache/iceberg/catalog/Catalog.java:
##
@@ -271,7 +271,7 @@ default Transaction newReplaceTableTransaction(
}
/**
- * Check whet
dramaticlly commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1868679172
##
api/src/main/java/org/apache/iceberg/catalog/Catalog.java:
##
@@ -271,7 +271,7 @@ default Transaction newReplaceTableTransaction(
}
/**
- * Check whe
kevinjqliu commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1868677442
##
api/src/main/java/org/apache/iceberg/catalog/Catalog.java:
##
@@ -271,7 +271,7 @@ default Transaction newReplaceTableTransaction(
}
/**
- * Check whet
dramaticlly commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1868399294
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,34 @@ private void validateTableIsIcebergTableOrView(
}
}
+
dramaticlly commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1868398567
##
hive-metastore/src/test/java/org/apache/iceberg/hive/HiveTableTest.java:
##
@@ -388,6 +388,41 @@ public void
testHiveTableAndIcebergTableWithSameName(TableTyp
dramaticlly commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1868397742
##
hive-metastore/src/test/java/org/apache/iceberg/hive/HiveTableTest.java:
##
@@ -388,6 +388,41 @@ public void
testHiveTableAndIcebergTableWithSameName(TableTyp
szehon-ho commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1868396253
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,34 @@ private void validateTableIsIcebergTableOrView(
}
}
+ @
szehon-ho commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1868258764
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,34 @@ private void validateTableIsIcebergTableOrView(
}
}
+ @
gaborkaszab commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1867329974
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,34 @@ private void validateTableIsIcebergTableOrView(
}
}
+
pvary commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1867303394
##
api/src/main/java/org/apache/iceberg/catalog/Catalog.java:
##
@@ -271,7 +271,7 @@ default Transaction newReplaceTableTransaction(
}
/**
- * Check whether t
dramaticlly commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1866416964
##
hive-metastore/src/test/java/org/apache/iceberg/hive/HiveTableTest.java:
##
@@ -386,6 +386,12 @@ public void
testHiveTableAndIcebergTableWithSameName(TableTyp
dramaticlly commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1866414354
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,28 @@ private void validateTableIsIcebergTableOrView(
}
}
+
dramaticlly commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1866412255
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,28 @@ private void validateTableIsIcebergTableOrView(
}
}
+
dramaticlly commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1866408953
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,28 @@ private void validateTableIsIcebergTableOrView(
}
}
+
dramaticlly commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1866408953
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,28 @@ private void validateTableIsIcebergTableOrView(
}
}
+
kevinjqliu commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1859082300
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,28 @@ private void validateTableIsIcebergTableOrView(
}
}
+
kevinjqliu commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1859082627
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,28 @@ private void validateTableIsIcebergTableOrView(
}
}
+
gaborkaszab commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1857260261
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,28 @@ private void validateTableIsIcebergTableOrView(
}
}
+
szehon-ho commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1853417638
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,28 @@ private void validateTableIsIcebergTableOrView(
}
}
+ @
szehon-ho commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1853417638
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,28 @@ private void validateTableIsIcebergTableOrView(
}
}
+ @
szehon-ho commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1853417638
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,28 @@ private void validateTableIsIcebergTableOrView(
}
}
+ @
szehon-ho commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1853417638
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,28 @@ private void validateTableIsIcebergTableOrView(
}
}
+ @
szehon-ho commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1853420085
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,28 @@ private void validateTableIsIcebergTableOrView(
}
}
+ @
szehon-ho commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1853417638
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,28 @@ private void validateTableIsIcebergTableOrView(
}
}
+ @
pvary commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1853353750
##
hive-metastore/src/test/java/org/apache/iceberg/hive/HiveTableTest.java:
##
@@ -386,6 +386,12 @@ public void
testHiveTableAndIcebergTableWithSameName(TableType tabl
szehon-ho commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1853216938
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,28 @@ private void validateTableIsIcebergTableOrView(
}
}
+ @
kevinjqliu commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1853192695
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,28 @@ private void validateTableIsIcebergTableOrView(
}
}
+
szehon-ho commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1853169535
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,28 @@ private void validateTableIsIcebergTableOrView(
}
}
+ @
szehon-ho commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1853156033
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,26 @@ private void validateTableIsIcebergTableOrView(
}
}
+ @
dramaticlly commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1853138562
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,26 @@ private void validateTableIsIcebergTableOrView(
}
}
+
dramaticlly commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1853134029
##
hive-metastore/src/test/java/org/apache/iceberg/hive/HiveTableTest.java:
##
@@ -386,6 +386,12 @@ public void
testHiveTableAndIcebergTableWithSameName(TableTyp
dramaticlly commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1853129053
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,26 @@ private void validateTableIsIcebergTableOrView(
}
}
+
szehon-ho commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1853121710
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,26 @@ private void validateTableIsIcebergTableOrView(
}
}
+ @
karuppayya commented on PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#issuecomment-2492535997
Another minor behavioral change is , earlier if the user had access to both
HMS table and storage, the table exists would pass.
With the change, tableExists would pass with only ac
pvary commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1852056157
##
hive-metastore/src/test/java/org/apache/iceberg/hive/HiveTableTest.java:
##
@@ -386,6 +386,12 @@ public void
testHiveTableAndIcebergTableWithSameName(TableType tabl
pvary commented on PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#issuecomment-2491129221
Thanks for the check @dramaticlly!
I agree that this behavioural change is small, but I would like to raise
awareness around the community about this. Could you please write a letter to
dramaticlly commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1851116414
##
hive-metastore/src/test/java/org/apache/iceberg/hive/HiveTableTest.java:
##
@@ -386,6 +386,12 @@ public void
testHiveTableAndIcebergTableWithSameName(TableTyp
dramaticlly commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1851116414
##
hive-metastore/src/test/java/org/apache/iceberg/hive/HiveTableTest.java:
##
@@ -386,6 +386,12 @@ public void
testHiveTableAndIcebergTableWithSameName(TableTyp
dramaticlly commented on PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#issuecomment-2489434569
> Quick question: Is this a behavioral change? Previously we failed when the
metadata was corrupt. After this, we succeed.
>
> How do we handle corrupt metadata in other catal
pvary commented on PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#issuecomment-2487619096
Quick question: Is this a behavioral change? Previously we failed when the
metadata was corrupt. After this, we succeed.
How do we handle corrupt metadata in other catalog implement
pvary commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1849630441
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,25 @@ private void validateTableIsIcebergTableOrView(
}
}
+ @Over
dramaticlly commented on PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#issuecomment-2487035183
FYI @szehon-ho and @haizhou-zhao if you are interested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
60 matches
Mail list logo
