kevinjqliu commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1859082300
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -412,6 +412,28 @@ private void validateTableIsIcebergTableOrView(
}
}
+ @Override
+ public boolean tableExists(TableIdentifier identifier) {
+ if (!isValidIdentifier(identifier)) {
+ return false;
+ }
+
+ String database = identifier.namespace().level(0);
+ try {
+ Table table = clients.run(client -> client.getTable(database,
identifier.name()));
+ HiveOperationsBase.validateTableIsIceberg(table, fullTableName(name,
identifier));
+ return true;
+ } catch (NoSuchTableException | NoSuchObjectException e) {
+ return false;
Review Comment:
+1 to keep the behavior the same. Lets add a test to explicitly call out
this behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
