szehon-ho commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1868258764
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -412,6 +412,34 @@ private void validateTableIsIcebergTableOrView(
}
}
+ @Override
+ public boolean tableExists(TableIdentifier identifier) {
+ TableIdentifier baseTableIdentifier = identifier;
+ if (!isValidIdentifier(identifier)) {
+ if (!isValidMetadataIdentifier(identifier)) {
Review Comment:
Can we combine the two if condition here, or will it not work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
