dramaticlly commented on code in PR #11597: URL: https://github.com/apache/iceberg/pull/11597#discussion_r1866412255
########## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ########## @@ -412,6 +412,28 @@ private void validateTableIsIcebergTableOrView( } } + @Override + public boolean tableExists(TableIdentifier identifier) { + if (!isValidIdentifier(identifier)) { + return false; + } + + String database = identifier.namespace().level(0); + try { + Table table = clients.run(client -> client.getTable(database, identifier.name())); + HiveOperationsBase.validateTableIsIceberg(table, fullTableName(name, identifier)); + return true; + } catch (NoSuchTableException | NoSuchObjectException e) { + return false; Review Comment: I added test to cover this and also there's existing test `testHiveTableAndIcebergTableWithSameName` to cover as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org