szehon-ho commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1853121710
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -412,6 +412,26 @@ private void validateTableIsIcebergTableOrView(
}
}
+ @Override
+ public boolean tableExists(TableIdentifier identifier) {
+ if (!isValidIdentifier(identifier)) {
+ return false;
+ }
+
+ String database = identifier.namespace().level(0);
+ try {
+ Table table = clients.run(client -> client.getTable(database,
identifier.name()));
+ HiveOperationsBase.validateTableIsIceberg(table, fullTableName(name,
identifier));
+ return true;
+ } catch (NoSuchTableException | NoSuchObjectException e) {
+ return false;
+ } catch (TException e) {
+ throw new RuntimeException("Failed to check table existence of " +
identifier, e);
+ } catch (InterruptedException e) {
Review Comment:
Nit: do we need to do ' Thread.currentThread().interrupt();' as in
other parts of the code?
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -412,6 +412,26 @@ private void validateTableIsIcebergTableOrView(
}
}
+ @Override
+ public boolean tableExists(TableIdentifier identifier) {
+ if (!isValidIdentifier(identifier)) {
+ return false;
+ }
+
+ String database = identifier.namespace().level(0);
+ try {
+ Table table = clients.run(client -> client.getTable(database,
identifier.name()));
Review Comment:
There seems to be a API tableExists, can we use it? cc @pvary
``` boolean tableExists(String var1, String var2) throws MetaException,
TException, UnknownDBException;```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
