dramaticlly commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1868397742
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/HiveTableTest.java:
##########
@@ -388,6 +388,41 @@ public void
testHiveTableAndIcebergTableWithSameName(TableType tableType)
HIVE_METASTORE_EXTENSION.metastoreClient().dropTable(DB_NAME,
hiveTableName);
}
+ @Test
+ public void testTableExists() throws TException, IOException {
+ String testTableName = "test_table_exists";
+ TableIdentifier identifier = TableIdentifier.of(DB_NAME, testTableName);
+ TableIdentifier metadataIdentifier = TableIdentifier.of(DB_NAME,
testTableName, "partitions");
+
+ assertThat(catalog.tableExists(identifier))
+ .as("Table should not exist before create")
+ .isFalse();
+ catalog.buildTable(identifier, SCHEMA).create();
+ assertThat(catalog.tableExists(identifier)).as("Table should exist after
create").isTrue();
+ assertThat(catalog.tableExists(metadataIdentifier))
+ .as("Metadata table should also exist")
+ .isTrue();
+
+ boolean dropped = catalog.dropTable(identifier);
+ assertThat(dropped).as("Should drop a table that does exist").isTrue();
+ assertThat(catalog.tableExists(identifier)).as("Table should not exist
after drop").isFalse();
+ assertThat(catalog.tableExists(metadataIdentifier))
+ .as("Metadata table should not exist after drop")
+ .isFalse();
+
+ // recreate a hive table with the same name shall return false instead of
throw exception
+ HIVE_METASTORE_EXTENSION
+ .metastoreClient()
+ .createTable(createHiveTable(testTableName, TableType.EXTERNAL_TABLE));
+ assertThat(catalog.tableExists(identifier))
+ .as("Catalog shall return false even if hive table with the same name
exists")
+ .isFalse();
+ assertThat(catalog.tableExists(metadataIdentifier))
+ .as("Metadata table should not exist")
+ .isFalse();
+ HIVE_METASTORE_EXTENSION.metastoreClient().dropTable(DB_NAME,
testTableName);
+ }
Review Comment:
Sure, added for check table existence on iceberg view and expect to return
false
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/HiveTableTest.java:
##########
@@ -388,6 +388,41 @@ public void
testHiveTableAndIcebergTableWithSameName(TableType tableType)
HIVE_METASTORE_EXTENSION.metastoreClient().dropTable(DB_NAME,
hiveTableName);
}
+ @Test
+ public void testTableExists() throws TException, IOException {
+ String testTableName = "test_table_exists";
+ TableIdentifier identifier = TableIdentifier.of(DB_NAME, testTableName);
+ TableIdentifier metadataIdentifier = TableIdentifier.of(DB_NAME,
testTableName, "partitions");
+
+ assertThat(catalog.tableExists(identifier))
+ .as("Table should not exist before create")
+ .isFalse();
+ catalog.buildTable(identifier, SCHEMA).create();
Review Comment:
added empty line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
