szehon-ho commented on code in PR #11597: URL: https://github.com/apache/iceberg/pull/11597#discussion_r1870097657
########## api/src/main/java/org/apache/iceberg/catalog/Catalog.java: ########## @@ -271,7 +271,7 @@ default Transaction newReplaceTableTransaction( } /** - * Check whether table exists. + * Check whether table or metadata table exists. Review Comment: Yea I think the main concern with putting on top level javadoc is that , there's a lot of Catalog in the wild that may not (and may not want to) support this. As @kevinjqliu points out it seems its a bit of an outlier that it happened here (that we should keep for backward compatbiility) and doc can probably be added in HiveCatalog specifically for this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
