kevinjqliu commented on code in PR #11597: URL: https://github.com/apache/iceberg/pull/11597#discussion_r1868686474
########## api/src/main/java/org/apache/iceberg/catalog/Catalog.java: ########## @@ -271,7 +271,7 @@ default Transaction newReplaceTableTransaction( } /** - * Check whether table exists. + * Check whether table or metadata table exists. Review Comment: Thanks! I didn't know about this behavior. Changing this doc string in the `Catalog` interface will also change the doc string for functions that overrides `tableExists`. For example, the [`EcsCatalog`](https://github.com/apache/iceberg/blob/6501d29b2d46c8d57f46ad646e2daf7d8865f646/dell/src/main/java/org/apache/iceberg/dell/ecs/EcsCatalog.java#L373-L376) overrides the `tableExists` and inherits the doc string in its javadocs https://iceberg.apache.org/javadoc/1.7.0/org/apache/iceberg/dell/ecs/EcsCatalog.html but it doesn't look like this behavior is supported in the `EcsCatalog`. There are a couple more places where this happens https://grep.app/search?q=boolean%20tableExists%28&filter[repo.pattern][0]=apache/iceberg Perhaps it is better to move this into `HiveCatalog` or any other catalogs that support this behavior to avoid confusion in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
