kevinjqliu commented on code in PR #11597: URL: https://github.com/apache/iceberg/pull/11597#discussion_r1870085840
########## api/src/main/java/org/apache/iceberg/catalog/Catalog.java: ########## @@ -271,7 +271,7 @@ default Transaction newReplaceTableTransaction( } /** - * Check whether table exists. + * Check whether table or metadata table exists. Review Comment: the metadata table concept only applied to `loadTable` right now https://github.com/search?q=repo%3Aapache%2Ficeberg%20isValidMetadataIdentifier&type=code so its a side effect of [`tableExists` using the underlying `loadTable` function](https://github.com/apache/iceberg/blob/8c04bcb876d46e953ece5b2951c9bd2f361783df/api/src/main/java/org/apache/iceberg/catalog/Catalog.java#L279-L286) on a meta level, its a bit weird to check if a metadata table exists. if the underlying iceberg table exists, I would assume its metadata table also exists. that said, I'm in favor of documenting this hidden behavior of `tableExists` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
