dramaticlly commented on code in PR #11597: URL: https://github.com/apache/iceberg/pull/11597#discussion_r1868763730
########## api/src/main/java/org/apache/iceberg/catalog/Catalog.java: ########## @@ -271,7 +271,7 @@ default Transaction newReplaceTableTransaction( } /** - * Check whether table exists. + * Check whether table or metadata table exists. Review Comment: I think it's otherwise, all other catalog reuse the default implementation where they tried to load table first as a way to determine whether table exists. The ECSCatalog is the only concrete implementation override this method which might not handle the metadata tables. Partly it was because such behaviour was implicit without unit test or documentation, until @szehon-ho mentioned it in https://github.com/apache/iceberg/pull/11597#discussion_r1853169535 My vote is that we can override the javadoc in ECSCatalog instead, what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
