dramaticlly commented on code in PR #11597: URL: https://github.com/apache/iceberg/pull/11597#discussion_r1866414354
########## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ########## @@ -412,6 +412,28 @@ private void validateTableIsIcebergTableOrView( } } + @Override + public boolean tableExists(TableIdentifier identifier) { + if (!isValidIdentifier(identifier)) { Review Comment: Good catch, I added unit test to cover this and also clarify in javadoc to account for metadata tables -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org