dramaticlly commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1853129053
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -412,6 +412,26 @@ private void validateTableIsIcebergTableOrView(
}
}
+ @Override
+ public boolean tableExists(TableIdentifier identifier) {
+ if (!isValidIdentifier(identifier)) {
+ return false;
+ }
+
+ String database = identifier.namespace().level(0);
+ try {
+ Table table = clients.run(client -> client.getTable(database,
identifier.name()));
Review Comment:
yeah that's what I initially intend to use, what I think this return true
for either hive or iceberg table, the later
`HiveOperationsBase.validateTableIsIceberg(table, fullTableName(name,
identifier));` rely on instance of HiveTable to ensure it's of iceberg table
type by checking its table properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
