dramaticlly commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1851116414
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/HiveTableTest.java:
##########
@@ -386,6 +386,12 @@ public void
testHiveTableAndIcebergTableWithSameName(TableType tableType)
assertThat(catalog.tableExists(TABLE_IDENTIFIER)).isTrue();
HIVE_METASTORE_EXTENSION.metastoreClient().dropTable(DB_NAME,
hiveTableName);
+
Review Comment:
I agree however this change I proposed here does not introduce new feature
but rather simplify the existing flow. I found out existing test coverage is
sufficient on the behaviour of checking table existence of iceberg table in
HiveCatalog, but I still try to add a bit more to ensure it's working as
expected. If you have some recommendations in mind, I am happy to create a new
one!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
