pvary commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1852056157
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/HiveTableTest.java:
##########
@@ -386,6 +386,12 @@ public void
testHiveTableAndIcebergTableWithSameName(TableType tableType)
assertThat(catalog.tableExists(TABLE_IDENTIFIER)).isTrue();
HIVE_METASTORE_EXTENSION.metastoreClient().dropTable(DB_NAME,
hiveTableName);
+
Review Comment:
I would prefer to have a separate test for the `tableExists`.
```
@Test
public void testTableExists() throws TException {
[..]
// create an iceberg table after hive table dropped
catalog.createTable(identifier, SCHEMA, PartitionSpec.unpartitioned());
assertThat(catalog.tableExists(identifier)).isTrue();
catalog.dropTable(identifier, true);
assertThat(catalog.tableExists(identifier)).isFalse();
[..]
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
