Adam Litke has submitted this change and it was merged.
Change subject: Update mom version to 0.4.5
..
Update mom version to 0.4.5
Change-Id: Idbe9a0cf54edb360dffa42269044dbad359375cc
Signed-off-by: Martin Sivak
Reviewed-on: h
Adam Litke has posted comments on this change.
Change subject: Update mom version to 0.4.5
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.ovirt.org/42240
To unsubscribe, visit https://gerrit.ovirt.or
Adam Litke has posted comments on this change.
Change subject: Allow using unix socket for the RPC port
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42228
To unsubscribe, visit https://gerrit.ovirt.
Adam Litke has submitted this change and it was merged.
Change subject: Allow using unix socket for the RPC port
..
Allow using unix socket for the RPC port
This adds a code that is able to start an XML-RPC server listening
on
Adam Litke has posted comments on this change.
Change subject: Allow using unix socket for the RPC port
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/42228/2/configure.ac
File configure.ac:
Line 17
Line 18
Line 19
Adam Litke has submitted this change and it was merged.
Change subject: New hypervisor interface for remote VDSM over XML-RPC with
stats caching
..
New hypervisor interface for remote VDSM over XML-RPC with stats caching
This
Adam Litke has submitted this change and it was merged.
Change subject: Improve 'and' and 'or' operators to accept unlimited number of
arguments
..
Improve 'and' and 'or' operators to accept unlimited number of arguments
It wa
Adam Litke has submitted this change and it was merged.
Change subject: Include line number in parsing and runtime policy error messages
..
Include line number in parsing and runtime policy error messages
The current code only
Adam Litke has submitted this change and it was merged.
Change subject: Define argument types for builtins and operators
..
Define argument types for builtins and operators
Signed-off-by: Martin Sivak
Change-Id: I2bd1bb96099e6
Adam Litke has posted comments on this change.
Change subject: New hypervisor interface for remote VDSM over XML-RPC with
stats caching
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41570
To unsubsc
Adam Litke has posted comments on this change.
Change subject: Define argument types for builtins and operators
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42042
To unsubscribe, visit https://gerri
Adam Litke has posted comments on this change.
Change subject: New hypervisor interface for remote VDSM over XML-RPC with
stats caching
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41570
To unsubsc
Adam Litke has posted comments on this change.
Change subject: Improve 'and' and 'or' operators to accept unlimited number of
arguments
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42041
To unsubsc
Adam Litke has posted comments on this change.
Change subject: Include line number in parsing and runtime policy error messages
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42043
To unsubscribe, vis
Adam Litke has posted comments on this change.
Change subject: New hypervisor interface for remote VDSM over XML-RPC with
stats caching
..
Patch Set 6:
(2 comments)
Looks good overall. Just a few small things that I do think
Adam Litke has submitted this change and it was merged.
Change subject: guest manager, monitor: remove implicit start()
..
guest manager, monitor: remove implicit start()
For classes which inherit from threading.Thread(),
impli
Adam Litke has submitted this change and it was merged.
Change subject: hypervisor interface: inherit from object
..
hypervisor interface: inherit from object
make sure the HypervisorInterface inherits from object.
Change-Id:
Adam Litke has posted comments on this change.
Change subject: hypervisor interface: inherit from object
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41224
To unsubscribe, visit https://gerrit.ovirt
Adam Litke has posted comments on this change.
Change subject: monitor: simplify should_run implementation
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41378
To unsubscribe, visit https://gerrit.ovi
Adam Litke has posted comments on this change.
Change subject: Update mom version to 0.4.4
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40962
To unsubscribe, visit https://gerrit.ovirt.org/settings
Adam Litke has submitted this change and it was merged.
Change subject: Update mom version to 0.4.4
..
Update mom version to 0.4.4
Change-Id: I03f6701704d26fc7707014a3c81237a4b7dbd5b5
Signed-off-by: Adam Litke
Reviewed-on: htt
Adam Litke has posted comments on this change.
Change subject: Update mom version to 0.4.4
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40962
To unsubscribe, visit https://gerrit.ovirt.org/settings
Ge
Adam Litke has uploaded a new change for review.
Change subject: Update mom version to 0.4.4
..
Update mom version to 0.4.4
Change-Id: I03f6701704d26fc7707014a3c81237a4b7dbd5b5
Signed-off-by: Adam Litke
---
M configure.ac
1 fil
Adam Litke has posted comments on this change.
Change subject: monitor: implement NUMA aware KSM policy
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40130
To unsubscribe, visit https://gerrit.ovirt.
Adam Litke has submitted this change and it was merged.
Change subject: monitor: implement NUMA aware KSM policy
..
monitor: implement NUMA aware KSM policy
Add parameter to HostKSM.py collector to collect merge_across_nodes
Ad
Adam Litke has submitted this change and it was merged.
Change subject: print more user friendly error when VM is powered down while
running collectors
..
print more user friendly error when VM is powered down while running col
Adam Litke has posted comments on this change.
Change subject: print more user friendly error when VM is powered down while
running collectors
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/35883
To
Adam Litke has posted comments on this change.
Change subject: monitor: implement NUMA aware KSM policy
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/40130/2/mom/Entity.py
File mom/Entity.py:
Line 143: def Cont
Adam Litke has posted comments on this change.
Change subject: vdsm: make use of the new onlyUUID parameter
..
Patch Set 4:
(1 comment)
I really want to understand the implications of the Conflicts: lines in the
spec file bef
Adam Litke has posted comments on this change.
Change subject: collect: add support for bulk stats
..
Patch Set 3: Code-Review+1
(1 comment)
Seems sane to me. Still thinking a bit if there is a slicker way to abstract
the bu
Adam Litke has posted comments on this change.
Change subject: guest manager: single-thread monitoring
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37826
To unsubscribe, visit http://gerrit.ovirt.org
Adam Litke has posted comments on this change.
Change subject: GuestManager: reorganize internals
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37825
To unsubscribe, visit http://gerrit.ovirt.org/sett
Adam Litke has posted comments on this change.
Change subject: guest monitor: split monitor from thread
..
Patch Set 10: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31591
To unsubscribe, visit http://gerrit.ovirt.o
Adam Litke has posted comments on this change.
Change subject: janitorial: use contextmanagers for semaphores
..
Patch Set 10: Code-Review+1
(1 comment)
As long as we're okay to depend on python-2.6 then this one looks good to
Adam Litke has posted comments on this change.
Change subject: guest manager, monitor: remove implicit start()
..
Patch Set 9: Code-Review+2
Thanks! We will want this in any case.
--
To view, visit http://gerrit.ovirt.org/31
Adam Litke has submitted this change and it was merged.
Change subject: logging: fix the exception handler
..
logging: fix the exception handler
In the exception handler of the MOM class constructor, there
are two issues
- one
Adam Litke has posted comments on this change.
Change subject: logging: fix the exception handler
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/37816
To unsubscribe, visit http://gerrit.ovirt.org/sett
Adam Litke has posted comments on this change.
Change subject: build: packaging: ship systemd service file
..
Patch Set 1:
That is it really. In system mode, mom should get its configuration and policy
from /etc (the default
Adam Litke has posted comments on this change.
Change subject: build: packaging: ship systemd service file
..
Patch Set 1:
Have you tested out the systemd script? Is it working for you?
--
To view, visit http://gerrit.ovirt.
Adam Litke has submitted this change and it was merged.
Change subject: guest monitor: add an interval attribute
..
guest monitor: add an interval attribute
Expose the monitoring interval as a GuestMonitor attribute.
A future p
Adam Litke has posted comments on this change.
Change subject: guest monitor: add an interval attribute
..
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/31590
To unsubscribe, visit http://gerrit.ovirt.or
Adam Litke has posted comments on this change.
Change subject: vdsm: use new VDSM APIs to improve efficiency
..
Patch Set 1: Code-Review-1
(1 comment)
Need to address BC issues.
http://gerrit.ovirt.org/#/c/37180/1/mom/Hypervi
Adam Litke has submitted this change and it was merged.
Change subject: Making the tests optional
..
Making the tests optional
Disabled by default as that's the default behavior we want at the project (run
the tests when you wa
Adam Litke has posted comments on this change.
Change subject: Making the tests optional
..
Patch Set 1:
please verify
--
To view, visit http://gerrit.ovirt.org/36122
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Adam Litke has posted comments on this change.
Change subject: Making the tests optional
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/36122
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ger
Adam Litke has posted comments on this change.
Change subject: guest monitor: add an interval attribute
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/31590
To unsubscribe, visit http://gerrit.ovirt.or
Adam Litke has posted comments on this change.
Change subject: added support for controlling iotune params
..
Patch Set 3:
Is this one still relevant?
--
To view, visit http://gerrit.ovirt.org/31251
To unsubscribe, visit http
Adam Litke has submitted this change and it was merged.
Change subject: Remove unused import
..
Remove unused import
Leftover, because Plotter is not used at all in this file.
Change-Id: Ib0682ae7225c1ddb532ff815f4cb6055b9ce44
Adam Litke has posted comments on this change.
Change subject: Remove unused import
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit http://gerrit.ovirt.org/35411
To unsubscribe, visit http://gerrit.ovirt.org/setting
Adam Litke has posted comments on this change.
Change subject: guest monitor: add an interval attribute
..
Patch Set 5:
Hi Francesco, If you still want to see this one merged, please verify it.
--
To view, visit http://gerri
Adam Litke has posted comments on this change.
Change subject: print more user friendly error when VM is powered down while
running collectors
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/35883/2/mom/
Adam Litke has submitted this change and it was merged.
Change subject: packaging: bump version to 0.4.3
..
packaging: bump version to 0.4.3
Change-Id: I1178233cfc0f0d56615f867efe04e4c58ba2ce41
Signed-off-by: Sandro Bonazzola
Adam Litke has posted comments on this change.
Change subject: packaging: bump version to 0.4.3
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35588
To unsubscribe, visit http://gerrit.ovirt.org/settin
Adam Litke has submitted this change and it was merged.
Change subject: CpuTune - use previous value if quota or period is None
..
CpuTune - use previous value if quota or period is None
The policy may not set the value of quot
Adam Litke has posted comments on this change.
Change subject: CpuTune - use previous value if quota or period is None
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35329
To unsubscribe, visit http://
Adam Litke has posted comments on this change.
Change subject: CpuTune - use previous value if quota or period is None
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35329
To unsubscribe, visit http://
Adam Litke has posted comments on this change.
Change subject: Track and log exceptions during thread init
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35437
To unsubscribe, visit http://gerrit.ovirt.or
Adam Litke has posted comments on this change.
Change subject: Track and log exceptions during thread init
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35437
To unsubscribe, visit http://gerrit.ovirt
Adam Litke has submitted this change and it was merged.
Change subject: Track and log exceptions during thread init
..
Track and log exceptions during thread init
We are currently tracking and logging exceptions that happen in
Adam Litke has uploaded a new change for review.
Change subject: Track and log exceptions during thread init
..
Track and log exceptions during thread init
We are currently tracking and logging exceptions that happen in mom
thre
Adam Litke has submitted this change and it was merged.
Change subject: Improve the way we declare and use (optional) collector fields
..
Improve the way we declare and use (optional) collector fields
Entity and Monitor objects
Adam Litke has posted comments on this change.
Change subject: Improve the way we declare and use (optional) collector fields
..
Patch Set 9:
Looks nice, and covers the cases I was concerned about.
--
To view, visit http://ge
Adam Litke has posted comments on this change.
Change subject: Improve the way we declare and use (optional) collector fields
..
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34528
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: jobs: add mom build
..
Patch Set 3: Code-Review+1
Let's activate the mom build job and fix the underlying issue separately as
David suggests.
--
To view, visit h
Adam Litke has posted comments on this change.
Change subject: GuestMemory fields should be optional
..
Patch Set 8: Code-Review-1
(2 comments)
Just a couple of minor things. Please address my recurring comment about
swap_us
Adam Litke has posted comments on this change.
Change subject: guest manager, monitor: remove implicit start()
..
Patch Set 3:
Sorry Francesco. It seems this one needs a rebase again.
--
To view, visit http://gerrit.ovirt.or
Adam Litke has posted comments on this change.
Change subject: guest manager, monitor: remove implicit start()
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/31589
To unsubscribe, visit http://gerrit.o
Adam Litke has submitted this change and it was merged.
Change subject: janitorial: guest monitor: simplify getGuestName()
..
janitorial: guest monitor: simplify getGuestName()
The get() method of the dictionaries has the same
Adam Litke has posted comments on this change.
Change subject: GuestMemory fields should be optional
..
Patch Set 5: Code-Review-1
(1 comment)
Martin, yes. We decided to create a new Collector for this in order to
maintain B
Adam Litke has submitted this change and it was merged.
Change subject: Add valid function to the policy parser
..
Add valid function to the policy parser
This new valid function accepts any number of arguments and returns
True
Adam Litke has posted comments on this change.
Change subject: Add valid function to the policy parser
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34791
To unsubscribe, visit http://gerrit.ovirt.org
Adam Litke has posted comments on this change.
Change subject: Documentation: document the mandatory field behavior
..
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35011
To unsubscribe, visit
Adam Litke has submitted this change and it was merged.
Change subject: Documentation: document the mandatory field behavior
..
Documentation: document the mandatory field behavior
Make it clear how mandatory field absence shou
Adam Litke has posted comments on this change.
Change subject: janitorial: guest monitor: simplify getGuestName()
..
Patch Set 3:
ping?
--
To view, visit http://gerrit.ovirt.org/31588
To unsubscribe, visit http://gerrit.ovirt
Adam Litke has posted comments on this change.
Change subject: Separate constants from rules to collector, read it from XML
..
Patch Set 1: Code-Review-1
(2 comments)
Please see my alternate suggestion in the comments...
http
Adam Litke has submitted this change and it was merged.
Change subject: Add missing log for getStatistics in XMLRPC interface
..
Add missing log for getStatistics in XMLRPC interface
All methods exported to XMLRPC interface has
Adam Litke has posted comments on this change.
Change subject: Add missing log for getStatistics in XMLRPC interface
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34712
To unsubscribe, visit http://ge
Adam Litke has posted comments on this change.
Change subject: GuestMemory fields should be optional
..
Patch Set 4:
ping?
--
To view, visit http://gerrit.ovirt.org/34528
To unsubscribe, visit http://gerrit.ovirt.org/settings
Adam Litke has posted comments on this change.
Change subject: Add valid function to the policy parser
..
Patch Set 3: Code-Review-1
(1 comment)
-1 for visibility only.
http://gerrit.ovirt.org/#/c/34791/3/tests/ParserTests.py
Adam Litke has submitted this change and it was merged.
Change subject: build: Fix mom.spec.in changelog
..
build: Fix mom.spec.in changelog
During the rewrite of the mom build process (707326d4) an old bug in our
spec file cre
Adam Litke has posted comments on this change.
Change subject: build: Fix mom.spec.in changelog
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34937
To unsubscribe, visit http://gerrit.ovirt.org/settin
Adam Litke has posted comments on this change.
Change subject: build: Fix mom.spec.in changelog
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/34937
To unsubscribe, visit http://gerrit.ovirt.org/settings
Adam Litke has uploaded a new change for review.
Change subject: build: Fix mom.spec.in changelog
..
build: Fix mom.spec.in changelog
During the rewrite of the mom build process (707326d4) an old bug in our
spec file crept back
Adam Litke has posted comments on this change.
Change subject: Add valid function to the policy parser
..
Patch Set 2:
(1 comment)
Looks good. See comment for an idea to enhance the tests.
http://gerrit.ovirt.org/#/c/34791/2
Adam Litke has posted comments on this change.
Change subject: GuestMemory fields should be optional
..
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/34528/4/mom/Collectors/GuestMemory.py
File mom/Collectors/GuestMemor
Adam Litke has posted comments on this change.
Change subject: GuestMemory fields should be optional
..
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/34528/4/mom/Entity.py
File mom/Entity.py:
Line 90: Get the
Adam Litke has posted comments on this change.
Change subject: GuestMemory fields should be optional
..
Patch Set 4: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/34528/4/mom/Collectors/GuestMemory.py
File mom/Collect
Adam Litke has posted comments on this change.
Change subject: GuestMonitor fields should be optional
..
Patch Set 3:
(1 comment)
I suggest calculating the average based on only the non-None values.
http://gerrit.ovirt.org/#/
Adam Litke has posted comments on this change.
Change subject: GuestMonitor fields should be optional
..
Patch Set 3: Code-Review-1
(3 comments)
Please see comments. Also, this patch is not complete. You must also fix the
s
Adam Litke has submitted this change and it was merged.
Change subject: Correct typo in vcpuLimit name element
..
Correct typo in vcpuLimit name element
There is typo in name of XML element - vcpulimit is incorrect, because
it
Adam Litke has posted comments on this change.
Change subject: HostKSM: Gracefully handle ksmd pid lookup failure
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34378
To unsubscribe, visit http://gerri
Adam Litke has submitted this change and it was merged.
Change subject: HostKSM: Gracefully handle ksmd pid lookup failure
..
HostKSM: Gracefully handle ksmd pid lookup failure
In case the pid of ksmd cannot be found we current
Adam Litke has posted comments on this change.
Change subject: HostKSM: Gracefully handle ksmd pid lookup failure
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/34378
To unsubscribe, visit http://gerrit.o
Adam Litke has posted comments on this change.
Change subject: HostKSM: Gracefully handle ksmd pid lookup failure
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34378/1/mom/Collectors/HostKSM.py
File mom/Collectors/Ho
Adam Litke has uploaded a new change for review.
Change subject: HostKSM: Gracefully handle ksmd pid lookup failure
..
HostKSM: Gracefully handle ksmd pid lookup failure
In case the pid of ksmd cannot be found we currently fail
Adam Litke has posted comments on this change.
Change subject: Correct typo in vcpuLimit name element
..
Patch Set 1: Code-Review+2
Looks good. Please mark verify when you have tested it.
--
To view, visit http://gerrit.ovir
Adam Litke has submitted this change and it was merged.
Change subject: Fix a bug - collector mandatory fields were used instead of
optional
..
Fix a bug - collector mandatory fields were used instead of optional
Change-Id: I9
Adam Litke has posted comments on this change.
Change subject: Fix a bug - collector mandatory fields were used instead of
optional
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/33321
To unsubscribe,
Adam Litke has posted comments on this change.
Change subject: jobs: add mom build
..
Patch Set 3:
It looks like momd is failing in initialize. That's why you have a None type
where we are expecting an API handle. I would re
Adam Litke has posted comments on this change.
Change subject: Fix a bug - collector mandatory fields were used instead of
optional
..
Patch Set 1: Code-Review+1
Looks good. Please verify.
--
To view, visit http://gerrit.ov
1 - 100 of 307 matches
Mail list logo
