Adam Litke has submitted this change and it was merged. Change subject: guest manager, monitor: remove implicit start() ......................................................................
guest manager, monitor: remove implicit start() For classes which inherit from threading.Thread(), implicit start() in __init__ is generally considered a bad idea. This patch makes the start() explicit for better clarity. Moreover, future patches want to control the actual starting of threads, so this patch paves the road for them. Change-Id: Ia06bc0d9db0f53ae4c50aa7d25956ec626d8a1cc Signed-off-by: Francesco Romani <from...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/31589 Reviewed-by: Adam Litke <ali...@redhat.com> Reviewed-by: Jenkins CI --- M mom/GuestManager.py M mom/GuestMonitor.py M mom/__init__.py 3 files changed, 2 insertions(+), 2 deletions(-) Approvals: Adam Litke: Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/31589 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia06bc0d9db0f53ae4c50aa7d25956ec626d8a1cc Gerrit-PatchSet: 12 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
