Adam Litke has posted comments on this change. Change subject: vdsm: use new VDSM APIs to improve efficiency ......................................................................
Patch Set 1: Code-Review-1 (1 comment) Need to address BC issues. http://gerrit.ovirt.org/#/c/37180/1/mom/HypervisorInterfaces/vdsmInterface.py File mom/HypervisorInterfaces/vdsmInterface.py: Line 47: Line 48: def getVmList(self): Line 49: vmIds = [] Line 50: try: Line 51: response = self.vdsm_api.getVMListByStatus('Up') If we're depending on a new API here we need to handle BC with the old API. All versions of oVirt use the same latest version of MOM so we cannot break any supported version of oVirt. Line 52: self._check_status(response) Line 53: vmIds = response['vmList'] Line 54: self.logger.debug('VM List: %s', vmIds) Line 55: return vmIds -- To view, visit http://gerrit.ovirt.org/37180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5241e20c1e35866bfbb5a643ae00e463dcac2e Gerrit-PatchSet: 1 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
