Adam Litke has posted comments on this change. Change subject: HostKSM: Gracefully handle ksmd pid lookup failure ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34378/1/mom/Collectors/HostKSM.py File mom/Collectors/HostKSM.py: Line 54: out = proc.communicate()[0] Line 55: if proc.returncode == 0: Line 56: return int(out) Line 57: else: Line 58: return -1 > nit: None is a more pythonic way of saying "I found no pid". It's a fair point. Originally I was dynamically looking up the pid using a @property decorator and in that case None had a different meaning (not yet tried). Since I am not doing it that way anymore, it's easy for me to fix. Line 59: Line 60: def open_files(self): Line 61: self.files = {} Line 62: for datum in self.sysfs_keys: -- To view, visit http://gerrit.ovirt.org/34378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccd14ee44f4f7d8d9107e692c9faa27e7c487790 Gerrit-PatchSet: 1 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
