Adam Litke has posted comments on this change. Change subject: collect: add support for bulk stats ......................................................................
Patch Set 3: Code-Review+1 (1 comment) Seems sane to me. Still thinking a bit if there is a slicker way to abstract the bulk stats collection... ie. encapsulate it inside the hypervisor interface and have that class maintain a cache that it will refresh as necessary. Then the collectors can continue to make individualized hypervisorinterface stats calls like they always have. What do you think? http://gerrit.ovirt.org/#/c/37827/3/mom/Collectors/Collector.py File mom/Collectors/Collector.py: Line 34 Line 35 Line 36 Line 37 Line 38 Please describe the stats parameter here. -- To view, visit http://gerrit.ovirt.org/37827 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34c990f20d0597258a62fedff3fbf15300901fe6 Gerrit-PatchSet: 3 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
