Adam Litke has posted comments on this change. Change subject: GuestMonitor fields should be optional ......................................................................
Patch Set 3: Code-Review-1 (3 comments) Please see comments. Also, this patch is not complete. You must also fix the sample policy files to ensure that fields which can now be absent during policy execution are handled properly. This means adding a parameter to the Stat() and StatAvg() functions in Entity.py where a default value can be set and always accessing optional fields using these updated accessor functions. http://gerrit.ovirt.org/#/c/34528/3//COMMIT_MSG Commit Message: Line 4: Commit: Roy Golan <rgo...@redhat.com> Line 5: CommitDate: 2014-10-28 17:04:05 +0200 Line 6: Line 7: GuestMonitor fields should be optional Line 8: GuestMemory fields should be optional Line 9: Guest monitor fields might be missing since we don't rely on guest agent Line 10: for controllers like CpuTune. Therefor its fields are optional from now Line 11: one Line 12: Line 7: GuestMonitor fields should be optional Line 8: Line 9: Guest monitor fields might be missing since we don't rely on guest agent Line 10: for controllers like CpuTune. Therefor its fields are optional from now Line 11: one on. Line 12: Line 13: Change-Id: I631056568b5a69e18f6ed02730c41ab59f460aad Line 14: Bug-Url: https://bugzilla.redhat.com/1143992 http://gerrit.ovirt.org/#/c/34528/3/mom/Collectors/GuestMemory.py File mom/Collectors/GuestMemory.py: Line 25: def getFields(self=None): Line 26: return set() Line 27: Line 28: def getOptionalFields(self=None): Line 29: return self.hypervisor_iface.getStatsFields + set(["swap_total", "swap_usage"]) Please update the HypervisorInterface classes to just return the swap fields in getStatsFields() if they support it. vdsm does, libvirt does not. Line 30: Line 31: def __init__(self, properties): Line 32: self.hypervisor_iface = properties['hypervisor_iface'] Line 33: self.uuid = properties['uuid'] -- To view, visit http://gerrit.ovirt.org/34528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I631056568b5a69e18f6ed02730c41ab59f460aad Gerrit-PatchSet: 3 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
