Adam Litke has posted comments on this change. Change subject: monitor: implement NUMA aware KSM policy ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40130/2/mom/Entity.py File mom/Entity.py: Line 143: def Control(self, name, val): Line 144: """ Line 145: Set a control variable in this instance. Line 146: """ Line 147: # self.logger.debug("set Control %s=%s", name, val) I am not a fan of commented out code. Why not just add this at the trace logging level? Line 148: self.controls[name] = val Line 149: Line 150: def GetControl(self, name): Line 151: """ -- To view, visit https://gerrit.ovirt.org/40130 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26caf0abe0a33a82b242549ba2ba4ad7f01ec925 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
