Adam Litke has posted comments on this change. Change subject: Add valid function to the policy parser ......................................................................
Patch Set 3: Code-Review-1 (1 comment) -1 for visibility only. http://gerrit.ovirt.org/#/c/34791/3/tests/ParserTests.py File tests/ParserTests.py: Line 356: self.e.stack.set('guest', guest, True) Line 357: pol = """ Line 358: guest.num Line 359: (== guest.num nil) Line 360: (== guest.num 0) I meant for you to test the 'valid' keyword here too. Line 361: """ Line 362: self.verify(pol, [None, True, False]) Line 363: Line 364: if __name__ == '__main__': -- To view, visit http://gerrit.ovirt.org/34791 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5aa31886811593860c75cf13bf7743e85fde7358 Gerrit-PatchSet: 3 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
