Adam Litke has posted comments on this change. Change subject: GuestMonitor fields should be optional ......................................................................
Patch Set 3: (1 comment) I suggest calculating the average based on only the non-None values. http://gerrit.ovirt.org/#/c/34528/3/mom/Collectors/GuestMemory.py File mom/Collectors/GuestMemory.py: Line 25: def getFields(self=None): Line 26: return set() Line 27: Line 28: def getOptionalFields(self=None): Line 29: return self.hypervisor_iface.getStatsFields + set(["swap_total", "swap_usage"]) > I'm not sure what you mean Instead of adding set(["swap_total", "swap_usage"]) here, why not just make self.hypervisor_iface.getStatsFields() return it. Also, you broke the call to getStatsFields above since you deleted the (). Line 30: Line 31: def __init__(self, properties): Line 32: self.hypervisor_iface = properties['hypervisor_iface'] Line 33: self.uuid = properties['uuid'] -- To view, visit http://gerrit.ovirt.org/34528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I631056568b5a69e18f6ed02730c41ab59f460aad Gerrit-PatchSet: 3 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
