Adam Litke has posted comments on this change. Change subject: print more user friendly error when VM is powered down while running collectors ......................................................................
Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/35883/2/mom/HypervisorInterfaces/vdsmInterface.py File mom/HypervisorInterfaces/vdsmInterface.py: Line 220: Line 221: class vdsmException(Exception): Line 222: Line 223: def __init__(self, response, logger): Line 224: self.msg = response I agree with Martin that this fallback assignment should be moved into the except block. Line 225: try: Line 226: self.msg = response['status'].get('message', response) Line 227: except (AttributeError, KeyError): Line 228: pass -- To view, visit http://gerrit.ovirt.org/35883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I027b090a785883f79c7a678e8505c7e1d18bf2a8 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
