Adam Litke has posted comments on this change. Change subject: New hypervisor interface for remote VDSM over XML-RPC with stats caching ......................................................................
Patch Set 6: (2 comments) Looks good overall. Just a few small things that I do think are worth considering since they have long-term API/BC considerations. https://gerrit.ovirt.org/#/c/41570/6/mom/HypervisorInterfaces/vdsmxmlrpcInterface.py File mom/HypervisorInterfaces/vdsmxmlrpcInterface.py: Line 44: return memoizer Line 45: return decorator Line 46: Line 47: Line 48: class XmlRpcVdsmInterface(HypervisorInterface): Have you thought about what the transition to the JsonRPC interface would look like? Do we want that to be handled transparently by mom or do we want the users to configure a new HypervisorInterface for that? If we want transparency then perhaps we should change this name to VdsmRpcInterface. Line 49: """ Line 50: vdsmInterface provides a wrapper for the VDSM API so that VDSM- Line 51: related error handling can be consolidated in one place. An instance of Line 52: this class provides a single VDSM connection that can be shared by all Line 67: def _check_status(self, response): Line 68: if response['status']['code']: Line 69: raise vdsmException(response, self.logger) Line 70: Line 71: @memoize(expiration=5) Maybe a constant for the expiration? Line 72: def getAllVmStats(self): Line 73: vms = {} Line 74: Line 75: try: -- To view, visit https://gerrit.ovirt.org/41570 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I314f39f9020ee257827145a57f585e7921a913e3 Gerrit-PatchSet: 6 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
