Adam Litke has posted comments on this change. Change subject: janitorial: use contextmanagers for semaphores ......................................................................
Patch Set 10: Code-Review+1 (1 comment) As long as we're okay to depend on python-2.6 then this one looks good to me. http://gerrit.ovirt.org/#/c/31587/10//COMMIT_MSG Commit Message: Line 7: janitorial: use contextmanagers for semaphores Line 8: Line 9: Since python 2.6, threading.Semaphores can be used as context managers, Line 10: leading to neater and shorter code. Line 11: This patch changes the code to do that. Does MOM need to run on RHEL5 anymore? My guess is no. This was the only reason I didn't initially adopt this approach. Line 12: Line 13: Change-Id: Ifa1d4c8866263a612bbfa2ef706f91d6fdca7a6b -- To view, visit http://gerrit.ovirt.org/31587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa1d4c8866263a612bbfa2ef706f91d6fdca7a6b Gerrit-PatchSet: 10 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
