Adam Litke has posted comments on this change. Change subject: vdsm: make use of the new onlyUUID parameter ......................................................................
Patch Set 4: (1 comment) I really want to understand the implications of the Conflicts: lines in the spec file before merging. https://gerrit.ovirt.org/#/c/38709/4/mom.spec.in File mom.spec.in: Line 23: Conflicts: vdsm <= 4.16.8.1-9 Line 24: %else Line 25: Conflicts: vdsm <= 4.16.12 Line 26: %endif Line 27: Up to this point, it has been possible to update mom to the latest version on all supported platforms and we did not need to maintain multiple released versions with fixes backported. Can someone explain the implications of this specfile change? Who's going to stop getting mom updates once this patch is applied? Line 28: # MOM makes use of libvirt by way of the python bindings to monitor and Line 29: # interact with virtual machines. Line 30: %if 0%{?fedora} >= 18 || 0%{?rhel} >= 7 Line 31: Requires: libvirt-daemon-driver-qemu -- To view, visit https://gerrit.ovirt.org/38709 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7020c9bd182b0af7bfedb0d221025fd3c01abaca Gerrit-PatchSet: 4 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches