Adam Litke has posted comments on this change. Change subject: Add valid function to the policy parser ......................................................................
Patch Set 2: (1 comment) Looks good. See comment for an idea to enhance the tests. http://gerrit.ovirt.org/#/c/34791/2/tests/ParserTests.py File tests/ParserTests.py: Line 341: (valid) Line 342: (valid nil) Line 343: """ Line 344: self.verify(pol, [False, True, True, False]) Line 345: Does it make sense to test that None (inside an entity) will be seen as nil in the policy? You could so something like we do in test_with() to create a fake Entity with an attribute that evaluates to None. Line 346: if __name__ == '__main__': -- To view, visit http://gerrit.ovirt.org/34791 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5aa31886811593860c75cf13bf7743e85fde7358 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
