Omer Frenkel has posted comments on this change.
Change subject: core: change how async tasks are persisted using
TaskHandlerCommand
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16398
T
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: vnic custom properties should have the same permissions
as vm c.p
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fixing JSON derialization of VM
..
core: Fixing JSON derialization of VM
Adding another JsonIgnore to JsonVmMixIn.
Apararently @JsonIgnore annota
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fixing JSON derialization of VM
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16405
To unsubscribe, visi
Roy Golan has posted comments on this change.
Change subject: core: Fixing JSON derialization of VM
..
Patch Set 2: Looks good to me, approved
pls urgent - a unit test for Json serializations.
--
To view, visit http://gerrit.
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fixing JSON derialization of VM
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16405
To unsubscribe, visi
Yair Zaslavsky has posted comments on this change.
Change subject: core: Don't create Guid from String in DAO module
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16392
To unsubscribe, vi
Mike Kolesnik has posted comments on this change.
Change subject: core: Don't create Guid from String in DAO module
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16392
To unsubscribe, vis
Allon Mureinik has posted comments on this change.
Change subject: core: Don't create Guid from String in DAO module
..
Patch Set 3:
In both cases, new Guid is implemented on columns which are not null in the
database, so ther
Sandro Bonazzola has posted comments on this change.
Change subject: network: firewalld: avoid error if not available
..
Patch Set 1: (1 inline comment)
File src/plugins/otop
Roy Golan has posted comments on this change.
Change subject: packaging: make clean target use DEV_EXTRA_BUILD_FLAG
..
Patch Set 1: (1 inline comment)
File Makefile
Line 194:
Yair Zaslavsky has posted comments on this change.
Change subject: core: change how async tasks are persisted using
TaskHandlerCommand
..
Patch Set 1:
Omer, Roy - please take a look (virt side)
--
To view, visit http://gerri
Mike Kolesnik has posted comments on this change.
Change subject: core: Don't create Guid from String in DAO module
..
Patch Set 3: I would prefer that you didn't submit this
You missed my comment:
Please note there are some p
Yair Zaslavsky has posted comments on this change.
Change subject: core: change how async tasks are persisted using
TaskHandlerCommand
..
Patch Set 1: Looks good to me, but someone else must approve
Infra side - looks good.
-
Mike Kolesnik has posted comments on this change.
Change subject: core: Allow custom OpenStack Network plugin type
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, no changes since acked by masayag
--
To view, vi
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Allow custom OpenStack Network plugin type
..
core: Allow custom OpenStack Network plugin type
The plugin type should be specifiable by the user,
Yair Zaslavsky has posted comments on this change.
Change subject: fix path in README.developers
..
Patch Set 1: (1 inline comment)
File README.developer
Line 189:
Line 190:
Yair Zaslavsky has posted comments on this change.
Change subject: [WIP] API: Adding monitored commands to ...
..
Patch Set 1: (1 inline comment)
File
backend/manager/module
Moti Asayag has posted comments on this change.
Change subject: core: Allow custom OpenStack Network plugin type
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16407
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: core: Example: Use UUID for handling database Guids
..
Patch Set 4: (1 inline comment)
File
backend/manager/
Alex Lourie has posted comments on this change.
Change subject: packaging: added DB validation functions
..
Patch Set 9: (4 inline comments)
File packaging/setup/plugins/ovir
Alon Bar-Lev has posted comments on this change.
Change subject: Using ssh username and password to install and update host
..
Patch Set 16: (1 inline comment)
File
backend/
Alon Bar-Lev has posted comments on this change.
Change subject: core: i18n welcome page with branding
..
Patch Set 4: (1 inline comment)
File packaging/branding/ovirt.brand/
Alexander Wels has posted comments on this change.
Change subject: core: i18n welcome page with branding
..
Patch Set 4: (1 inline comment)
File packaging/branding/ovirt.bran
Eli Mesika has posted comments on this change.
Change subject: core: Fix async tasks insertion to include time zone info
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16365
To unsubscribe
Eli Mesika has submitted this change and it was merged.
Change subject: core: Fix async tasks insertion to include time zone info
..
core: Fix async tasks insertion to include time zone info
Similar to other places (i.e - audit
Eli Mesika has posted comments on this change.
Change subject: core: Fix async tasks insertion to include time zone info
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16365
To u
Alon Bar-Lev has posted comments on this change.
Change subject: core: i18n welcome page with branding
..
Patch Set 4: (1 inline comment)
File packaging/branding/ovirt.brand/
Alexander Wels has posted comments on this change.
Change subject: core: i18n welcome page with branding
..
Patch Set 4: (1 inline comment)
File packaging/branding/ovirt.bran
Eli Mesika has posted comments on this change.
Change subject: [WIP] API: Adding JobResource and JobsResource...
..
Patch Set 1: (1 inline comment)
File
backend/manager/modu
Eli Mesika has posted comments on this change.
Change subject: [WIP] API: Adding BackendStepResource and ...
..
Patch Set 1: (3 inline comments)
File
backend/manager/modules
Eli Mesika has posted comments on this change.
Change subject: [WIP] API: Adding StepResource and StepsResource..
..
Patch Set 1: (1 inline comment)
File
backend/manager/mod
Eli Mesika has posted comments on this change.
Change subject: [WIP] API: Adding BackendJobResource...
..
Patch Set 1: (4 inline comments)
File
backend/manager/modules/resta
Eli Mesika has posted comments on this change.
Change subject: [WIP] API: Adding jobs to root searchable keywords
..
Patch Set 1: (1 inline comment)
Commit Message
Line 3: Au
Eli Mesika has posted comments on this change.
Change subject: [WIP] API: Adding monitored commands to ...
..
Patch Set 1: (2 inline comments)
File
backend/manager/modules/r
Eli Mesika has posted comments on this change.
Change subject: [WIP] API: Adding Step mapping class
..
Patch Set 1: (10 inline comments)
File
backend/manager/modules/restapi
Eli Mesika has posted comments on this change.
Change subject: [WIP] API: Adding Job mapper class
..
Patch Set 1: (10 inline comments)
File
backend/manager/modules/restapi/t
Daniel Erez has posted comments on this change.
Change subject: userportal: No MLA filtering for VM disks
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/16396
To unsub
Alissa Bonas has posted comments on this change.
Change subject: engine: Enable online virtual drive resize
..
Patch Set 8: (9 inline comments)
Sorry, didn't review everything, but here are some comments...
...
Alon Bar-Lev has posted comments on this change.
Change subject: core: i18n welcome page with branding
..
Patch Set 4: (1 inline comment)
File packaging/branding/ovirt.brand/
Alon Bar-Lev has posted comments on this change.
Change subject: network: firewalld: avoid error if not available
..
Patch Set 1: (1 inline comment)
File src/plugins/otopi/ne
Alon Bar-Lev has posted comments on this change.
Change subject: Applying usage for public key authentication method
..
Patch Set 8: Looks good to me, but someone else must approve
Looks good!
--
To view, visit http://gerrit.
Alon Bar-Lev has posted comments on this change.
Change subject: Wrap validation of fingerprint in each connect using
EngineSSHClient
..
Patch Set 12:
EngineSSHClient.java gone?
--
To view, visit http://gerrit.ovirt.org/1612
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: added DB validation functions
..
Patch Set 9: (4 inline comments)
thanks!!! minor formatting comments left.
..
Alexander Wels has posted comments on this change.
Change subject: core: i18n welcome page with branding
..
Patch Set 4: (1 inline comment)
File packaging/branding/ovirt.bran
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: make clean target use DEV_EXTRA_BUILD_FLAG
..
Patch Set 1: (1 inline comment)
File Makefile
Line 1
Alon Bar-Lev has posted comments on this change.
Change subject: core: i18n welcome page with branding
..
Patch Set 4: (1 inline comment)
File packaging/branding/ovirt.brand/
Alexander Wels has posted comments on this change.
Change subject: core: i18n welcome page with branding
..
Patch Set 4: (5 inline comments)
File packaging/branding/ovirt.bra
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: log setup events - add otopi upgrade
..
Patch Set 6: Looks good to me, but someone else must approve
Thanks!
--
To view, visit http://gerrit.o
Alon Bar-Lev has posted comments on this change.
Change subject: backend: Remove dbscripts package
..
Patch Set 1:
If Eli and Java people agree, this should be moved into the all target of the
Makefile.
This is in my queue to
Alon Bar-Lev has posted comments on this change.
Change subject: core: i18n welcome page with branding
..
Patch Set 4: (5 inline comments)
File packaging/branding/ovirt.brand
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: move log file for db scripts
..
Patch Set 2: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/16381
To unsu
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: move log file for db scripts
..
Patch Set 2: (2 inline comments)
File packaging/dbscripts/d
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: set log file for db upgrade
..
Patch Set 1: (2 inline comments)
File packaging/setup/plugin
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: set log file for db upgrade
..
Patch Set 1:
Hi,
See schema.py... I use the same log file of our setup:
'-l', self.environment[otopicons.CoreE
Alon Bar-Lev has posted comments on this change.
Change subject: oVirt Node Upgrade: Support N configuration
..
Patch Set 9: (2 inline comments)
File
backend/manager/modules
Alon Bar-Lev has posted comments on this change.
Change subject: fix path in README.developers
..
Patch Set 1: (1 inline comment)
File README.developer
Line 189:
Line 190: C
Alon Bar-Lev has posted comments on this change.
Change subject: doc: rename engine_dao database to engine_dao_tests
..
Patch Set 2: (1 inline comment)
File README.developer
Liran Zelkha has posted comments on this change.
Change subject: userportal: No MLA filtering for VM disks
..
Patch Set 1: Looks good to me, but someone else must approve
I will need to deploy and test this patch on Monday/Tues
Liran Zelkha has posted comments on this change.
Change subject: core: Improve performance of GUID constructor
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Improve performance of GUID constructor
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ge
Juan Hernandez has uploaded a new change for review.
Change subject: core: Improve performance of GUID constructor
..
core: Improve performance of GUID constructor
The GUID constructor that takes an array of bytes as parameter c
Alexander Wels has posted comments on this change.
Change subject: userportal,webadmin: Frontend refactor
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/15399
To unsubscribe, visit http://gerrit.ovirt.org/s
Yedidyah Bar David has posted comments on this change.
Change subject: network: firewalld: avoid error if not available
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/
Federico Simoncelli has posted comments on this change.
Change subject: [wip] backend: add the import glance image support
..
Patch Set 2: (8 inline comments)
File
backend/m
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Enable online virtual drive resize
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [wip] frontend: add glance storage domain support
..
Patch Set 4: Fails
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkst
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [wip] backend: add glance storage domain support
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: add alignment scan lost changes
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/204
Doron Fediuck has posted comments on this change.
Change subject: Use balloon_min to set the minimum guaranteed memory available
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.o
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [wip] backend: add the import glance image support
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checksty
Doron Fediuck has posted comments on this change.
Change subject: Teach min and max to MoM policy parser
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15800
To unsubs
Doron Fediuck has posted comments on this change.
Change subject: Fix the lexical priority of operators
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/16097
To unsubsc
Federico Simoncelli has posted comments on this change.
Change subject: [wip] backend: add glance storage domain support
..
Patch Set 4: (3 inline comments)
File
backend/man
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: introducing downloadImage vds command
..
Patch Set 8: Fails
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ge
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [wip] providers: add the openstack image support
..
Patch Set 4: Fails
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checksty
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [wip] frontend: add the export glance image support
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkst
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [wip] backend: add the export glance image support
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checksty
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [wip] frontend: add the import glance image support
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkst
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: introducing uploadImage vds command
..
Patch Set 9: Fails
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerr
Federico Simoncelli has posted comments on this change.
Change subject: core: add alignment scan lost changes
..
Patch Set 1: (1 inline comment)
File packaging/dbscripts/upgr
Federico Simoncelli has uploaded a new change for review.
Change subject: core: add alignment scan lost changes
..
core: add alignment scan lost changes
During the rebase of I4858b7bb few changes has been lost. This patch
reintr
Federico Simoncelli has uploaded a new change for review.
Change subject: [wip] backend: add the export glance image support
..
[wip] backend: add the export glance image support
Change-Id: Id93d40ebb812e4be8669ad14f6ba92aab4de2
Federico Simoncelli has uploaded a new change for review.
Change subject: [wip] frontend: add the export glance image support
..
[wip] frontend: add the export glance image support
Change-Id: If5ec1bd1de705233c3a0baf26e5f2a4c0a2
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Enable online virtual drive resize
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Modifying Reinstall Host popup view
..
Patch Set 10:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: API: Adding ssh username, port and fingerprint to host
information
..
Patch Set 9: Fails
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_sani
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Modifying Add\Edit Host popup view
..
Patch Set 12:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ge
Alissa Bonas has posted comments on this change.
Change subject: core: Removing a vitaly from RestoreFromSnapshot.
..
Patch Set 1: (1 inline comment)
Commit Message
Line 3: A
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Applying usage for public key authentication method
..
Patch Set 8: Fails
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_check
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Using ssh username and password to install and update host
..
Patch Set 16: Fails
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Wrap validation of fingerprint in each connect using
EngineSSHClient
..
Patch Set 12: Fails
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_s
Lior Vernia has posted comments on this change.
Change subject: webadmin: Added DC-per-network choice in Discovery popup
..
Patch Set 8: (1 inline comment)
File
frontend/web
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding ssh_username and ssh_port to VDS object - VdsStatic
fields
..
Patch Set 15: Fails
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_sani
Tal Nisan has posted comments on this change.
Change subject: core: Remove unreadable comment
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16415
To unsubscribe, visit http://gerrit.ovirt
Lior Vernia has posted comments on this change.
Change subject: webadmin: Disabled VNIC properties for external networks
..
Patch Set 8: (4 inline comments)
Still remains to be verified.
...
Tal Nisan has posted comments on this change.
Change subject: core: Example: Use UUID for handling database Guids
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16281
To unsubscribe, visit
Laszlo Hornyak has posted comments on this change.
Change subject: engine: watchdog - restapi support
..
Patch Set 36: (10 inline comments)
File
backend/manager/modules/rest
Tal Nisan has posted comments on this change.
Change subject: core: Don't create Guid from String in DAO module
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16392
To unsubscribe, visit h
Maor Lipchuk has posted comments on this change.
Change subject: core: Removing a vitaly from RestoreFromSnapshot.
..
Patch Set 1: (1 inline comment)
Commit Message
Line 3: A
1 - 100 of 392 matches
Mail list logo
